Resolve Promises in plugins tooltip #11266#11373
Open
smmhatami wants to merge 1 commit intochartjs:masterfrom
Open
Resolve Promises in plugins tooltip #11266#11373smmhatami wants to merge 1 commit intochartjs:masterfrom
smmhatami wants to merge 1 commit intochartjs:masterfrom
Conversation
Signed-off-by: Seyed Mohammad Mahdi Hatami <hatamik7@gmail.com>
Contributor
|
@smmhatami having a look to the changes, it's not clear to me how this could solve the mentioned issue. The issue is reporting a wrong visualization of the ticks on the scale and not the callback of tooltip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to solve Issue 11266. Resolves #11266. After investigating this issue I found the callback invocation in this file one of the sourced that would need to await for callback result which would solve mane occurrences of the mentioned issue.
Although I think there should be other parts of the code needing this change too. It would be great if somebody helps me with completing this.
Thanks!